[PATCH] D127409: Fix GCC intrinsics "round_mask" names

[Phoebe Wang via Phabricator via cfe-commits]

pengfei requested changes to this revision.
pengfei added a comment.
This revision now requires changes to proceed.

We had a discussion about the builtins between GCC and Clang on D109658 <https://reviews.llvm.org/D109658> last year. We tried to make sure the same builtins have the same arguments and behavior. There's still a big gap among others.
We don't pursue all the builtins are identical for two reasons:

- Builtins are compiler private interfaces which are not supposed to be used directly and no guaranteed across compilers. User should use intrinsics instead;
- Builtins are not 1:1 mapped between GCC and Clang, e.g., Clang prefer to use select rather than adding new mask builtins like GCC;

And changing the existing builtins will fall into a paradox: if we change it because there're quite a lot of user scenarios, then we cannot change it because the change will break user scenarios. And vice versa.
So I suggest to not change it, if you have to use builtins, you can use macro to distinguish each other.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127409/new/

https://reviews.llvm.org/D127409