[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 9 22:14:34 PDT 2022


junaire added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.h:1500
+
+    assert(WeakRefReferences.empty() &&
+           "Not all WeakRefRefs have been applied");
----------------
v.g.vassilev wrote:
> It seems that we forgot to move the `WeakRefReferences`?
Thanks for the heads up, I've added that in https://github.com/llvm/llvm-project/commit/0ecbedc0986bd4b7b90a60a5f31d32337160d4c4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126781/new/

https://reviews.llvm.org/D126781



More information about the cfe-commits mailing list