[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

Vassil Vassilev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 9 21:48:12 PDT 2022


v.g.vassilev added inline comments.


================
Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180
   DiagnosticsEngine &Diags = getCI()->getDiagnostics();
   if (Diags.hasErrorOccurred()) {
     TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl();
----------------
We should call Restore here. 


================
Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:251
 
+TEST(InterpreterTest, UndoBasic) {
+  Args ExtraArgs = {"-Xclang", "-diagnostic-log-file", "-Xclang", "-"};
----------------
Can we move this as a regular test called code-undo.cpp?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126682/new/

https://reviews.llvm.org/D126682



More information about the cfe-commits mailing list