[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

[John Ericson via Phabricator via cfe-commits]

Ericson2314 added inline comments.


================
Comment at: bolt/tools/CMakeLists.txt:11-13
+macro(add_bolt_tool_symlink name)
+  llvm_add_tool_symlink(BOLT ${ARGV})
+endmacro()
----------------
mizvekov wrote:
> Instead of each project having to define a different macro for this, why not just do this based on the current project in scope?
> I think this would be a less invasive change.
> 
> FWIW my review can only help in these small matters of coding, I can't really review this from the perspective of the intended effect, I am just a clang developer and I never have to package or install LLVM I built myself, I just test stuff from the build dir :)
`project` is not redefined in the unified / monorepo build, so we cannot rely on it.


================
Comment at: bolt/tools/CMakeLists.txt:11-13
+macro(add_bolt_tool_symlink name)
+  llvm_add_tool_symlink(BOLT ${ARGV})
+endmacro()
----------------
Ericson2314 wrote:
> mizvekov wrote:
> > Instead of each project having to define a different macro for this, why not just do this based on the current project in scope?
> > I think this would be a less invasive change.
> > 
> > FWIW my review can only help in these small matters of coding, I can't really review this from the perspective of the intended effect, I am just a clang developer and I never have to package or install LLVM I built myself, I just test stuff from the build dir :)
> `project` is not redefined in the unified / monorepo build, so we cannot rely on it.
> I am just a clang developer and I never have to package or install LLVM I built myself, I just test stuff from the build dir :)

You mean you build clang against a prebuilt LLVM? I am confused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117977/new/

https://reviews.llvm.org/D117977