[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo
Ryan Prichard via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 9 18:46:09 PDT 2022
rprichard added a subscriber: jlebar.
rprichard added a comment.
Ok, I can upload a patch omitting `*_ATOMIC_LLONG_LOCK_FREE` from the macro testing.
FWIW, did you see this comment in clang/lib/Basic/Targets/NVPTX.cpp?:
// This is a bit of a lie, but it controls __GCC_ATOMIC_XXX_LOCK_FREE, and
// we need those macros to be identical on host and device, because (among
// other things) they affect which standard library classes are defined, and
// we need all classes to be defined on both the host and device.
MaxAtomicInlineWidth = HostTarget->getMaxAtomicInlineWidth();
It was added in D24407 <https://reviews.llvm.org/D24407>, apparently so that `__GCC_ATOMIC_INT_LOCK_FREE` would be 2 instead of 1. I imagine that's OK, because NVPTX does have atomic int?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127267/new/
https://reviews.llvm.org/D127267
More information about the cfe-commits
mailing list