[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

[Gabor Marton via Phabricator via cfe-commits]

martong added inline comments.


================
Comment at: clang/docs/analyzer/checkers.rst:2553-2555
+The supported functions are the same that are modeled by checker
+:doc:`alpha.unix.StdCLibraryFunctionArgs` (and affect value of ``errno``),
+including effect of the ``ModelPOSIX`` option of that checker.
----------------
This sentence is a bit hard to follow, I'd split this up.


================
Comment at: clang/docs/analyzer/checkers.rst:2559-2560
+
+The ``AllowUnconditionalErrnoRead`` option allows reads of the errno value all
+times if the value is not used as a condition (at the first read). For example
+``errno`` can be stored into a variable without getting a warning from the
----------------
"all times" and "the first read" seems to be in contradiction to each other. Could you please rephrase? Use a standalone sentence that explains the "(at the first read)" part.


================
Comment at: clang/docs/analyzer/checkers.rst:2560
+The ``AllowUnconditionalErrnoRead`` option allows reads of the errno value all
+times if the value is not used as a condition (at the first read). For example
+``errno`` can be stored into a variable without getting a warning from the
----------------
?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122150/new/

https://reviews.llvm.org/D122150