[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

[Gabor Marton via Phabricator via cfe-commits]

martong added inline comments.


================
Comment at: clang/test/Analysis/errno-stdlibraryfunctions-notes.c:11
+
+int access(const char *path, int amode);
+
----------------
Do you plan to extend the test file for other standard functions as well?


================
Comment at: clang/test/Analysis/errno-stdlibraryfunctions.c:14-15
+typedef size_t ssize_t;
+ssize_t send(int sockfd, const void *buf, size_t len, int flags);
+off_t lseek(int fildes, off_t offset, int whence);
+
----------------
Do you plan to extend the test file for other standard functions as well?


================
Comment at: clang/test/Analysis/errno-stdlibraryfunctions.c:43-44
+      return 1;
+    }
+  }
+  if (result == offset) {
----------------
This should be reachable as well, isn't it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125400/new/

https://reviews.llvm.org/D125400