[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 9 02:54:01 PDT 2022


carlosgalvezp added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidConstOrRefDataMembersCheck.h:29
+  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+};
+
----------------
Eugene.Zelenko wrote:
> Please add `isLanguageVersionSupported`.
Done. I generated this check via `add_new_check.py` - should we add this there as well to avoid similar issues in the future (separate commit)?

I see some checks implement this function and some others don't, so it's not totally clear to me when is needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126880/new/

https://reviews.llvm.org/D126880



More information about the cfe-commits mailing list