[PATCH] D109977: LLVM Driver Multicall tool

[Nikita Popov via Phabricator via cfe-commits]

nikic added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:890
+    configure_file(
+      ${LLVM_MAIN_SRC_DIR}/cmake/driver-template.cpp.in
+      ${CMAKE_CURRENT_BINARY_DIR}/${name}-driver.cpp)
----------------
nikic wrote:
> nikic wrote:
> > chapuni wrote:
> > > Do you have a plan to export the template?
> > Unsurprisingly, this breaks standalone builds. However, I think that the multicall tool is fundamentally incompatible with standalone builds, in the sense that all tools included in it must be part of the initial build configuration -- you can't first build the LLVM multicall tool and then add clang to it afterwards.
> > 
> > So I think we just need to guard this code by LLVM_TOOL_LLVM_DRIVER_BUILD, so we don't try to read a non-exported driver-template.cpp.in file even if we're not actually building the multicall tool.
> Ah, I misunderstood how this works. Generating the driver file is necessary for //normal// usage, not for the mutlicall tool, so it's not possible to just guard this code. We do need to export driver-template.cpp.in as part of the LLVM cmake installation.
I've put up https://reviews.llvm.org/D127384 to fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109977/new/

https://reviews.llvm.org/D109977