[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 9 00:22:51 PDT 2022


sammccall added a comment.

This sounds correct to me, though I don't feel like an expert here.
Upstream in non-experimental IntWidth == Char32Width except on AVR, so it won't actually break anything.

Regarding testing, it seems like this should change the diagnostic emitted for `long x = 'abc'` from "Character constant too long for its type" to "Multi-character character constant" when the target is AVR?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127363/new/

https://reviews.llvm.org/D127363



More information about the cfe-commits mailing list