[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

[Nemanja Ivanovic via Phabricator via cfe-commits]

nemanjai added a comment.

In D127310#3567472 <https://reviews.llvm.org/D127310#3567472>, @MaskRay wrote:

> Do you have more authoritative answer when /root/usr is used and when it isn't?

These suffixes were always part of the code and the mentioned changeset removed it without any justification. The burden of providing this answer should lie with the author of the change that removed this (i.e. @tbaeder). Here at IBM, we are not aware of any Redhat release that does not have this suffix. Namely, all of our RH PowerPC machines with all the toolset versions and distro versions we have available have the suffix. So we are ill equipped to answer this question. I assume that Timm is aware of situations where this isn't part of the path.

> I'd wish that we have comments for them.

I agree 100%. Timm, do you know the answer to this and if so, can you propose a comment to that end?

> This change also needs a unit test.

+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127310/new/

https://reviews.llvm.org/D127310