[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 8 10:07:28 PDT 2022


rjmccall added a comment.

In D126781#3565173 <https://reviews.llvm.org/D126781#3565173>, @junaire wrote:

> I believe that `OldBuilder` is always valid in the normal cases, so
> remove the if condition and replace it with an assertion.

Is `StartModule` not called for the first time we start emitting a module, or do we pointlessly create a CGM and then immediately replace it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126781/new/

https://reviews.llvm.org/D126781



More information about the cfe-commits mailing list