[PATCH] D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances.

[weiyi via Phabricator via cfe-commits]

wyt marked 2 inline comments as done.
wyt added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:29
 /// Base class for all values computed by abstract interpretation.
+/// All Value instances should be separately allocated and stored by pointer
+/// for pointer stability.
----------------
gribozavr2 wrote:
> sgatev wrote:
> > I'm not sure I understand what is meant by "separately allocated" and "stored by pointer". Could you please clarify?
> 
(See suggested fix by Dmitri)
When we create a new Value instance, we let DataflowAnalysisCtx take ownership of the value and refer to it by pointer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127196/new/

https://reviews.llvm.org/D127196