[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added a comment.

In D126907#3563356 <https://reviews.llvm.org/D126907#3563356>, @erichkeane wrote:

> Ping!
>
> @ChuanqiXu : i was hoping you could take a look at this, since you did such a great job reviewing the rest of this (note this is mostly the same patch as the last one, just with the 'friends' stuff dealt with).

Hi, I am reviewing actually and I don't complete it since I am busy with coroutine and modules things recently. This is on my TODO list.



================
Comment at: clang/include/clang/Sema/Template.h:221-226
+    ArgListsIterator begin() { return TemplateArgumentLists.rbegin(); }
+    ConstArgListsIterator begin() const {
+      return TemplateArgumentLists.rbegin();
+    }
+    ArgListsIterator end() { return TemplateArgumentLists.rend(); }
+    ConstArgListsIterator end() const { return TemplateArgumentLists.rend(); }
----------------
The `begin()` and `end()` wrapper use `rbegin` and `rend` here. It is not straight forward. Is it matter?


================
Comment at: clang/lib/Sema/SemaConcept.cpp:169
       //    operand is satisfied.
-      return false;
+      return LHSRes.isUsable() ? BO.recreateBinOp(S, LHSRes) : ExprEmpty();
 
----------------



================
Comment at: clang/lib/Sema/SemaConcept.cpp:178
       //    the second operand is satisfied.
-      return false;
+      return LHSRes.isUsable() ? BO.recreateBinOp(S, LHSRes) : ExprEmpty();
 
----------------
ditto


================
Comment at: clang/lib/Sema/SemaConcept.cpp:185-186
+
+    if (!LHSRes.isUsable() || !RHSRes.isUsable())
+      return ExprEmpty();
+    return BO.recreateBinOp(S, LHSRes, RHSRes);
----------------



================
Comment at: clang/lib/Sema/SemaOverload.cpp:1041
+
+#if !NDEBUG
+  SmallVector<const Expr *, 3> NewAC;
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907