[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

Tue Jun 7 14:16:49 PDT 2022

tlively planned changes to this revision.
tlively added inline comments.

================
Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:190
+TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x16_s_i16x8, "V8sV16ScV16Sc", "nc", "relaxed-simd")
+TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x16_add_s_i32x4, "V4iV16ScV16Sc", "nc", "relaxed-simd")
+
----------------
aheejin wrote:
> Doesn't `i32x4.dot_i8x16_i7x16_add_s` take three operands? https://github.com/WebAssembly/relaxed-simd/blob/main/proposals/relaxed-simd/Overview.md#relaxed-integer-dot-product
Oh wow, good catch 😬 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127170/new/

https://reviews.llvm.org/D127170