[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

Hi, the test you modified in your change seems to be failing on the PS4 linux build bot at https://lab.llvm.org/buildbot/#/builders/139/builds/22964.

  ******************** TEST 'Clang :: Tooling/clang-diff-ast.cpp' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang-diff -ast-dump /home/buildbot/buildbot-root/llvm-project/clang/test/Tooling/clang-diff-ast.cpp -- -std=c++11 | /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-project/clang/test/Tooling/clang-diff-ast.cpp
  --
  Exit Code: 1
  Command Output (stderr):
  --
  /home/buildbot/buildbot-root/llvm-project/clang/test/Tooling/clang-diff-ast.cpp:50:12: error: CHECK: expected string not found in input
   // CHECK: StringLiteral: wide(
             ^
  <stdin>:35:21: note: scanning from here
   StringLiteral: foo(34)
                      ^
  <stdin>:39:2: note: possible intended match here
   StringLiteral: utf-16(38)
   ^
  Input file: <stdin>
  Check file: /home/buildbot/buildbot-root/llvm-project/clang/test/Tooling/clang-diff-ast.cpp
  -dump-input=help explains the following input dump.
  Input was:
  <<<<<<
              .
              .
              .
             30:  IfStmt(29) 
             31:  BinaryOperator: ==(30) 
             32:  DeclRefExpr: i(31) 
             33:  IntegerLiteral: 0(32) 
             34:  ReturnStmt(33) 
             35:  StringLiteral: foo(34) 
  check:50'0                         X~~~ error: no match found
             36:  CStyleCastExpr(35) 
  check:50'0     ~~~~~~~~~~~~~~~~~~~~
             37:  StringLiteral(36) 
  check:50'0     ~~~~~~~~~~~~~~~~~~~
             38:  CStyleCastExpr(37) 
  check:50'0     ~~~~~~~~~~~~~~~~~~~~
             39:  StringLiteral: utf-16(38) 
  check:50'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~
  check:50'1      ?                          possible intended match
             40:  CStyleCastExpr(39) 
  check:50'0     ~~~~~~~~~~~~~~~~~~~~
             41:  StringLiteral: utf-32(40) 
  check:50'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~
             42:  ReturnStmt(41) 
  check:50'0     ~~~~~~~~~~~~~~~~
             43:  IntegerLiteral: 0(42) 
  check:50'0     ~~~~~~~~~~~~~~~~~~~~~~~
             44:  AccessSpecDecl: public(43) 
  check:50'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              .
              .
              .
  >>>>>>
  --

Can you take a look and revert if you need time to investigate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126651/new/

https://reviews.llvm.org/D126651