[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:650
+                                  cast<llvm::PointerType>(NewVL->getType())));
+        BasicBlock *IsNotNull = createBasicBlock("newvl.isNotNull", this->CurFn);
+        BasicBlock *IsNull = createBasicBlock("newvl.isNull", this->CurFn);
----------------
I don't think we usually use capital letters in basic block names.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:651
+        BasicBlock *IsNotNull = createBasicBlock("newvl.isNotNull", this->CurFn);
+        BasicBlock *IsNull = createBasicBlock("newvl.isNull", this->CurFn);
+        Builder.CreateCondBr(Cmp, IsNotNull, IsNull);
----------------
newvl.isNull doesn't make sense since isNotNull eventually jumps to it.

Maybe use "store_newvl" and "store_newvl_end"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126461/new/

https://reviews.llvm.org/D126461