[PATCH] D126192: [Driver] Improve linking options for target AVR

Ben Shi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 6 20:40:14 PDT 2022


benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:507
+    // Add user specified linker script.
+    const Arg *LDS = Args.getLastArg(options::OPT_T);
+    if (LDS) {
----------------
MaskRay wrote:
> Just do  Args.AddAllArgs. Please check how Gnu.cpp passes `-T`
Thanks. `Args.AddAllArgs` does make code more clear.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126192/new/

https://reviews.llvm.org/D126192



More information about the cfe-commits mailing list