[clang] 834e5d1 - Revert "[gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in"

Akira Hatanaka via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 6 18:51:11 PDT 2022


Author: Akira Hatanaka
Date: 2022-06-06T18:48:24-07:00
New Revision: 834e5d12c77eaa4ac1f7fa9512bc7a71470318c7

URL: https://github.com/llvm/llvm-project/commit/834e5d12c77eaa4ac1f7fa9512bc7a71470318c7
DIFF: https://github.com/llvm/llvm-project/commit/834e5d12c77eaa4ac1f7fa9512bc7a71470318c7.diff

LOG: Revert "[gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in"

This reverts commit d1346e2ee2741919a8cc1b1ffe400001e76a6d06.

The commit broke a few bots.

Added: 
    

Modified: 
    clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp

Removed: 
    clang/test/Modules/Inputs/gmodules-deduction-guide.h
    clang/test/Modules/gmodules-deduction-guide.cpp


################################################################################
diff  --git a/clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp b/clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
index d03e5bd508731..9fe7e5d1f5c31 100644
--- a/clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
+++ b/clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
@@ -96,10 +96,6 @@ class PCHContainerGenerator : public ASTConsumer {
     }
 
     bool VisitFunctionDecl(FunctionDecl *D) {
-      // Skip deduction guides.
-      if (isa<CXXDeductionGuideDecl>(D))
-        return true;
-
       if (isa<CXXMethodDecl>(D))
         // This is not yet supported. Constructing the `this' argument
         // mandates a CodeGenFunction.

diff  --git a/clang/test/Modules/Inputs/gmodules-deduction-guide.h b/clang/test/Modules/Inputs/gmodules-deduction-guide.h
deleted file mode 100644
index 47b5931083af1..0000000000000
--- a/clang/test/Modules/Inputs/gmodules-deduction-guide.h
+++ /dev/null
@@ -1,11 +0,0 @@
-struct A {
-};
-
-template <class T>
-struct S{
-  S(const A &);
-};
-
-S(const A&) -> S<A>;
-
-typedef decltype(S(A())) Type0;

diff  --git a/clang/test/Modules/gmodules-deduction-guide.cpp b/clang/test/Modules/gmodules-deduction-guide.cpp
deleted file mode 100644
index 1017b76c82875..0000000000000
--- a/clang/test/Modules/gmodules-deduction-guide.cpp
+++ /dev/null
@@ -1,7 +0,0 @@
-// RUN: %clang_cc1 -std=c++2b -x c++-header -emit-pch -fmodule-format=obj -I %S/Inputs \
-// RUN:   -o %t.pch %S/Inputs/gmodules-deduction-guide.h \
-// RUN:   -mllvm -debug-only=pchcontainer &>%t-pch.ll
-// RUN: cat %t-pch.ll | FileCheck %s
-
-// CHECK: ![[V0:.*]] = distinct !DICompositeType(tag: DW_TAG_structure_type, name: "S<A>",
-// CHECK: !DIDerivedType(tag: DW_TAG_typedef, name: "Type0",{{.*}}, baseType: ![[V0]])


        


More information about the cfe-commits mailing list