[PATCH] D109977: LLVM Driver Multicall tool

[NAKAMURA Takumi via Phabricator via cfe-commits]

chapuni added a comment.

An interesting improvement. Thanks.



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:890
+    configure_file(
+      ${LLVM_MAIN_SRC_DIR}/cmake/driver-template.cpp.in
+      ${CMAKE_CURRENT_BINARY_DIR}/${name}-driver.cpp)
----------------
Do you have a plan to export the template?


================
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:1932
+    src = "//llvm:cmake/driver-template.cpp.in",
+    out = "clang_main.cpp",
+    substitutions = {
----------------
Could we unify generated names.cpp between cmake and bazel?

I am running a builder to compare each object file between  cmake and bazel. Such a difference appears in a few sections, at least in elf.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109977/new/

https://reviews.llvm.org/D109977