[PATCH] D127145: [Driver] add -lresolv for all but Android.

Evgenii Stepanov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 6 13:58:11 PDT 2022


eugenis added a comment.

The interceptor (dn_expand) is only defined on linux && !android, while this code links libresolv on *bsd and others, too. I think it's ok, as long as all platforms with the interceptor are covered.

It would be great to mention the actual reason we do this in the commit message: because otherwise link tests in ./configure scripts may be confused by the presence of the dn_expand symbol even without -lresolv (because of the interceptor) and get a runtime error later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127145/new/

https://reviews.llvm.org/D127145



More information about the cfe-commits mailing list