[libunwind] 64778c0 - [libunwind] Remove unused ARM SEH placeholder code

Martin Storsjö via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 6 13:28:08 PDT 2022


Author: Martin Storsjö
Date: 2022-06-06T23:24:22+03:00
New Revision: 64778c002a77046e15a7ce7a7206f5c15355fc26

URL: https://github.com/llvm/llvm-project/commit/64778c002a77046e15a7ce7a7206f5c15355fc26
DIFF: https://github.com/llvm/llvm-project/commit/64778c002a77046e15a7ce7a7206f5c15355fc26.diff

LOG: [libunwind] Remove unused ARM SEH placeholder code

There's no such corresponding code for ARM64 (which has been working
in production for years). The SEH version of the Unwind functions
(e.g. `_Unwind_GetLanguageSpecificData`) doesn't use these fields.

The `_Unwind_ForcedUnwind` function would need these bits though,
but that's not used in normal C++ exception unwinding.

Differential Revision: https://reviews.llvm.org/D126868

Added: 
    

Modified: 
    libunwind/src/UnwindCursor.hpp

Removed: 
    


################################################################################
diff  --git a/libunwind/src/UnwindCursor.hpp b/libunwind/src/UnwindCursor.hpp
index dc334edbe385..a46bbfbccdb5 100644
--- a/libunwind/src/UnwindCursor.hpp
+++ b/libunwind/src/UnwindCursor.hpp
@@ -1965,10 +1965,6 @@ bool UnwindCursor<A, R>::getInfoFromSEH(pint_t pc) {
       _info.handler = 0;
     }
   }
-#elif defined(_LIBUNWIND_TARGET_ARM)
-  _info.end_ip = _info.start_ip + unwindEntry->FunctionLength;
-  _info.lsda = 0; // FIXME
-  _info.handler = 0; // FIXME
 #endif
   setLastPC(pc);
   return true;


        


More information about the cfe-commits mailing list