[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

Mon Jun 6 09:29:04 PDT 2022

iains added a comment.

In D126694#3559818 <https://reviews.llvm.org/D126694#3559818>, @ChuanqiXu wrote:

> Given it touches ModuleOwnershipKind too and some codes looks similar to me (I haven't look into the it yet), I want to know if it is possible to make D113545 <https://reviews.llvm.org/D113545> a parent revision of this one? I feel like reachability might be more important than this one. Since reachability helps developers to use something but this functionality prevent developers to use something.

I will look at this - it is indeed a problem that currently we do not differentiate reachability from visibility - which means either some work-around, or making some thing artificially visible,
this patch would address your

  /// FIXME: Implement discarding declarations actually in global module
  /// fragment. See [module.global.frag]p3,4 for details.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126694/new/

https://reviews.llvm.org/D126694