[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 6 08:14:53 PDT 2022
rjmccall added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.h:1482
+
+ struct KeepLazyEmiitedSymRAII {
+ std::unique_ptr<CodeGenModule> OldBuilder;
----------------
I think a RAII object is an odd way to express this API; there's not really a natural reason you would scope this. It would be better to just have a method on `CodeGenModule` that steals the internal lazy-emission state from a different instance.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126781/new/
https://reviews.llvm.org/D126781
More information about the cfe-commits
mailing list