[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

[Vassil Vassilev via Phabricator via cfe-commits]

v.g.vassilev added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.h:1506
+
+  struct KeepLazyEmiitedSymRAII {
+    std::unique_ptr<CodeGenModule> OldBuilder;
----------------
Would it make sense to make the RAII a friend to avoid adding the accessors of various structures?


================
Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:138
+      {
+        CodeGenModule::KeepLazyEmiitedSymRAII RAIIKeeper(Builder);
+        M.reset(new llvm::Module(ExpandModuleName(ModuleName, CodeGenOpts), C));
----------------
Maybe we could move this call into `Initialize`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126781/new/

https://reviews.llvm.org/D126781