[PATCH] D109977: LLVM Driver Multicall tool

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 5 17:50:04 PDT 2022


phosek accepted this revision.
phosek added a comment.

LGTM



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:2030
+    string(REPLACE "-" "_" key ${link_name})
+    string(REPLACE "+" "p" key ${key})
+    string(REPLACE "llvm-" "" tool_name ${link_name})
----------------
Alternative substitution for `+` would be `x` which is used elsewhere in LLVM, for example `libcxx`, `libcxxabi` or `cxxfilt`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109977/new/

https://reviews.llvm.org/D109977



More information about the cfe-commits mailing list