[PATCH] D127075: [clang] P2266: apply move elision rules on throw expr nested in function prototypes
Matheus Izvekov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jun 5 13:04:16 PDT 2022
mizvekov created this revision.
Herald added a project: All.
mizvekov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Our rules to determine if the throw expression are within the variable
scope were giving a false negative result in case the throw expression
would appear within a decltype in a nested function declaration.
Per P2266R3, the relevant rule is: [expr.prim.id.unqual]/2
if the id-expression (possibly parenthesized) is the operand of a throw-expression, and names an implicitly movable entity that belongs to a scope that does not contain the compound-statement of the innermost lambda-expression, try-block , or function-try-block (if any) whose compound-statement or ctor-initializer encloses the throw-expression.
This fixes PR54341.
Signed-off-by: Matheus Izvekov <mizvekov at gmail.com>
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D127075
Files:
clang/lib/Sema/SemaExprCXX.cpp
clang/test/CXX/class/class.init/class.copy.elision/p3.cpp
Index: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp
===================================================================
--- clang/test/CXX/class/class.init/class.copy.elision/p3.cpp
+++ clang/test/CXX/class/class.init/class.copy.elision/p3.cpp
@@ -98,7 +98,7 @@
A1(const A1 &);
A1(A1 &&) = delete;
// expected-note at -1 2{{'A1' has been explicitly marked deleted here}}
- // cxx11_2b-note at -2 {{'A1' has been explicitly marked deleted here}}
+ // cxx11_2b-note at -2 3{{'A1' has been explicitly marked deleted here}}
};
void test1() {
try {
@@ -132,10 +132,10 @@
namespace PR54341 {
void test4(A1 a) {
void f(decltype((throw a, 0)));
- // expected-warning at -1 {{has no effect}}
+ // expected-error at -1 {{call to deleted constructor of 'test_throw_parameter::A1'}}
void g(int = decltype(throw a, 0){});
- // expected-warning at -1 {{has no effect}}
+ // expected-error at -1 {{call to deleted constructor of 'test_throw_parameter::A1'}}
}
void test5(A1 a, int = decltype(throw a, 0){}) {}
Index: clang/lib/Sema/SemaExprCXX.cpp
===================================================================
--- clang/lib/Sema/SemaExprCXX.cpp
+++ clang/lib/Sema/SemaExprCXX.cpp
@@ -845,8 +845,7 @@
if (S->getFlags() &
(Scope::FnScope | Scope::ClassScope | Scope::BlockScope |
- Scope::FunctionPrototypeScope | Scope::ObjCMethodScope |
- Scope::TryScope))
+ Scope::ObjCMethodScope | Scope::TryScope))
break;
}
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127075.434351.patch
Type: text/x-patch
Size: 1546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220605/27145dd2/attachment.bin>
More information about the cfe-commits
mailing list