[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

Fri Jun 3 11:38:48 PDT 2022

sammccall added inline comments.

================
Comment at: clang-tools-extra/pseudo/lib/grammar/Grammar.cpp:10
 #include "clang-pseudo/Grammar.h"
 #include "clang/Basic/TokenKinds.h"
 #include "llvm/ADT/ArrayRef.h"
----------------
hokein wrote:
> Add a trailing comment `// for clang::tok::TokenKind`?
> 
> Maybe even remove this include -- we have an include in the Grammar.h, though it makes this file less IWYU-friendly).
I'm not convinced about commenting particular includes (we include it in other places too, and these comments tend to get stale), and especially not dropping them in favor of transitive ones. Can you explain what this might help with?

(will land this but happy to follow up)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126731/new/

https://reviews.llvm.org/D126731