[PATCH] D126902: [Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax (NFC)

Fri Jun 3 06:46:11 PDT 2022

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a request to switch to an assert. Thanks for this cleanup!

================
Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3368
+  fn("C2x", C2x);
+  OS << "case AttributeCommonInfo::Syntax::AS_Keyword:\n";
+  OS << "case AttributeCommonInfo::Syntax::AS_ContextSensitiveKeyword:\n";
----------------
lgrey wrote:
> Not sure if this should be an assert or if 0 is fine.
I think this should probably be an assertion -- keyword attributes are sufficiently weird that I'd rather we not accidentally support this interface; we can intentionally support it later if we find a need.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126902/new/

https://reviews.llvm.org/D126902