[PATCH] D126759: [clang][dataflow] Model calls returning optionals

[Stanislav Gatev via Phabricator via cfe-commits]

sgatev marked an inline comment as done.
sgatev added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:161
 
+auto possiblyAliasedOptionalType() {
+  return hasUnqualifiedDesugaredType(
----------------
xazax.hun wrote:
> Does alias refers to a type alias in this case? I first parsed this as if this has something to do with pointers being aliased. I wonder if `possiblyOptionalAliasType` would read better (considering the optional type its own alias). Feel free to ignore. 
I opted for `hasOptionalOrAliasType`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126759/new/

https://reviews.llvm.org/D126759