[PATCH] D126934: [clang-format] NFC Sort names of format token types

[Owen Pan via Phabricator via cfe-commits]

owenpan added inline comments.


================
Comment at: clang/lib/Format/FormatToken.h:39-45
+  TYPE(CSharpGenericTypeConstraint)                                            \
+  TYPE(CSharpGenericTypeConstraintColon)                                       \
+  TYPE(CSharpGenericTypeConstraintComma)                                       \
+  TYPE(CSharpNamedArgumentColon)                                               \
+  TYPE(CSharpNullConditionalLSquare)                                           \
+  TYPE(CSharpNullable)                                                         \
+  TYPE(CSharpStringLiteral)                                                    \
----------------
Also use case-insensitive sorting and move them to just below `CppCastLParen` on line 55.


================
Comment at: clang/lib/Format/FormatToken.h:43-44
+  TYPE(CSharpNamedArgumentColon)                                               \
+  TYPE(CSharpNullConditionalLSquare)                                           \
+  TYPE(CSharpNullable)                                                         \
+  TYPE(CSharpStringLiteral)                                                    \
----------------
Can you swap them back? I think we want case-insensitive sorting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126934/new/

https://reviews.llvm.org/D126934