[PATCH] D119296: KCFI sanitizer

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

This lld/ELF change looks like a hack. I'll need to study what this patch does, but in the meanwhile I changed myself to a blocking reviewer as I think the lld/ELF change needs more investigation.



================
Comment at: lld/ELF/Symbols.cpp:553
+  // incompatible declarations for the same function.
+  if (isWeak() && getName().startswith("__kcfi_typeid_") &&
+      cast<Defined>(this)->value != other.value)
----------------
This change looks like a hack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119296/new/

https://reviews.llvm.org/D119296