[PATCH] D126862: [clang] [MSVC] Enable unwind tables for ARM

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.

This needs a test. There is existing testing gap as this change does not break any clang/test/Driver test.

  @@ -449,13 +449,15 @@ bool MSVCToolChain::IsUnwindTablesDefault(const ArgList &Args) const {
     // All non-x86_32 Windows targets require unwind tables. However, LLVM
     // doesn't know how to generate them for all targets, so only enable
     // the ones that are actually implemented.
  -  return getArch() == llvm::Triple::x86_64 ||
  -         getArch() == llvm::Triple::aarch64;
  +  //return getArch() == llvm::Triple::x86_64 ||
  +  //       getArch() == llvm::Triple::aarch64;
  +  return false;
   }

I think you may add windows-gnu RUN lines somewhere (perhaps mingw.cpp) to test both PIC and -funwind-tables= options, then remove windows-gnu RUN lines from `pic.c`.
(We should strive to use fewer RUN lines to achieve the same coverage.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126862/new/

https://reviews.llvm.org/D126862