[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 2 09:56:48 PDT 2022


MaskRay added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1228
       GV->setDLLStorageClass(llvm::GlobalVariable::DLLImportStorageClass);
-    else if (D->hasAttr<DLLExportAttr>() && !GV->isDeclarationForLinker())
+    else if ((D->hasAttr<DLLExportAttr>() ||
+              shouldMapVisibilityToDLLExport(D)) &&
----------------
Restrict this to AIX/XCOFF.

Really other binary format users will not need this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126340/new/

https://reviews.llvm.org/D126340



More information about the cfe-commits mailing list