[PATCH] D125052: [HLSL] Enable vector types for hlsl.

stan li via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 23:47:44 PDT 2022 

Cool. Thanks a lot.

Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows

From: Shubham Rastogi<mailto:srastogi22 at apple.com>
Sent: Wednesday, June 1, 2022 11:46 PM
To: stan li<mailto:python3kgae at outlook.com>
Cc: Shubham Sandeep Rastogi<mailto:reviews+D125052+public+3fe2be577b79c8be at reviews.llvm.org>; sven.vanhaastregt at arm.com<mailto:sven.vanhaastregt at arm.com>; andrew.savonichev at gmail.com<mailto:andrew.savonichev at gmail.com>; chris.bieneman at me.com<mailto:chris.bieneman at me.com>; goyoroth at gmail.com<mailto:goyoroth at gmail.com>; anastasia.stulova at arm.com<mailto:anastasia.stulova at arm.com>; thakis at chromium.org<mailto:thakis at chromium.org>; maskray at google.com<mailto:maskray at google.com>; cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>; mgorny at gentoo.org<mailto:mgorny at gentoo.org>; bhuvanendra.kumarn at amd.com<mailto:bhuvanendra.kumarn at amd.com>; 1135831309 at qq.com<mailto:1135831309 at qq.com>; gandhi21299 at gmail.com<mailto:gandhi21299 at gmail.com>; aeubanks at google.com<mailto:aeubanks at google.com>; mlekena at skidmore.edu<mailto:mlekena at skidmore.edu>; blitzrakete at gmail.com<mailto:blitzrakete at gmail.com>; shenhan at google.com<mailto:shenhan at google.com>; david.green at arm.com<mailto:david.green at arm.com>; simon.moll at emea.nec.com<mailto:simon.moll at emea.nec.com>
Subject: Re: [PATCH] D125052: [HLSL] Enable vector types for hlsl.

Hi Xiang,

I would be more than happy to test the fix for you :). Though it is 11:45 pm for me now and I am going to bed. But I can take a look tomorrow.

Thanks,

Shubham


On Jun 1, 2022, at 11:42 PM, stan li <python3kgae at outlook.com<mailto:python3kgae at outlook.com>> wrote:

Hi Shubham,

I found one issue in the change.
But I don’t have a Mac environment to test.
Could you help to test if this fix the issue?

The patch is in attachment.

Thanks
Xiang


Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows

From: Shubham Sandeep Rastogi via Phabricator<mailto:reviews at reviews.llvm.org>
Sent: Wednesday, June 1, 2022 11:28 PM
To: python3kgae at outlook.com<mailto:python3kgae at outlook.com>; sven.vanhaastregt at arm.com<mailto:sven.vanhaastregt at arm.com>; andrew.savonichev at gmail.com<mailto:andrew.savonichev at gmail.com>; chris.bieneman at me.com<mailto:chris.bieneman at me.com>; goyoroth at gmail.com<mailto:goyoroth at gmail.com>; anastasia.stulova at arm.com<mailto:anastasia.stulova at arm.com>
Cc: srastogi22 at apple.com<mailto:srastogi22 at apple.com>; thakis at chromium.org<mailto:thakis at chromium.org>; maskray at google.com<mailto:maskray at google.com>; cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>; mgorny at gentoo.org<mailto:mgorny at gentoo.org>; bhuvanendra.kumarn at amd.com<mailto:bhuvanendra.kumarn at amd.com>;1135831309 at qq.com<mailto:1135831309 at qq.com>; gandhi21299 at gmail.com<mailto:gandhi21299 at gmail.com>; aeubanks at google.com<mailto:aeubanks at google.com>; mlekena at skidmore.edu<mailto:mlekena at skidmore.edu>; blitzrakete at gmail.com<mailto:blitzrakete at gmail.com>; shenhan at google.com<mailto:shenhan at google.com>;david.green at arm.com<mailto:david.green at arm.com>; simon.moll at emea.nec.com<mailto:simon.moll at emea.nec.com>
Subject: [PATCH] D125052: [HLSL] Enable vector types for hlsl.

rastogishubham added a comment.

Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command:

xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=Debug -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DLLVM_ENABLE_PROJECTS='clang;' -DCMAKE_IGNORE_PATH="/usr/lib;/usr/local/lib;/lib" -DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64" ../llvm

I get:

  CMake Error in /Users/shubham/Development/llvm-project/clang/lib/Headers/CMakeLists.txt:
    The custom command generating

      /Users/shubham/Development/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/hlsl.h

    is attached to multiple targets:

      hlsl-resource-headers
      clang-resource-headers

    but none of these is a common dependency of the other(s).  This is not
    allowed by the Xcode "new build system".


  CMake Error in /Users/shubham/Development/llvm-project/third-party/benchmark/CMakeLists.txt:
    The custom command generating

      /Users/shubham/Development/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/hlsl.h

    is attached to multiple targets:

      hlsl-resource-headers
      clang-resource-headers

    but none of these is a common dependency of the other(s).  This is not
    allowed by the Xcode "new build system".


  CMake Generate step failed.  Build files cannot be regenerated correctly.

This is similar to the issue that was found in this patch: https://reviews.llvm.org/D123498


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125052/new/

https://reviews.llvm.org/D125052

<header_install.patch>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220602/5f163db1/attachment-0001.html>

More information about the cfe-commits mailing list