[PATCH] D126757: Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 2 00:41:19 PDT 2022


nridge added a comment.

It seems you have uploaded just the changes relative to the previous patch. If you made a second commit, you need to `squash` it into the first and resubmit.

Otherwise the test looks good, thanks!



================
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:811
+      )cpp",
+      // Template specialization
+      R"cpp(
----------------
nit: `// Explicit template specialization` to be a bit more specific


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126757/new/

https://reviews.llvm.org/D126757



More information about the cfe-commits mailing list