[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

[Timm Bäder via Phabricator via cfe-commits]

tbaeder marked 2 inline comments as done.
tbaeder added inline comments.


================
Comment at: clang/unittests/Driver/ToolChainTest.cpp:623
+  IntrusiveRefCntPtr<DiagnosticIDs> DiagID(new DiagnosticIDs());
+  struct TestDiagnosticConsumer : public DiagnosticConsumer {};
+
----------------
MaskRay wrote:
> delete `public`.
> 
> Can you avoid using a derived DiagnosticConsumer?
I can use the `SimpleDiagnosticConsumer` class created earlier in the file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125862/new/

https://reviews.llvm.org/D125862