[PATCH] D126291: [flang][Driver] Update link job on windows

[Diana Picus via Phabricator via cfe-commits]

rovka added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:753
+                                  llvm::opt::ArgStringList &CmdArgs) {
+  if (TC.getTriple().isOSWindows()) {
+    CmdArgs.push_back("Fortran_main.lib");
----------------
mmuetzel wrote:
> Are those correct for MinGW? Should this be checking for `TC.getTriple().isKnownWindowsMSVCEnvironment()` instead?
Right, I hadn't considered MinGW. Thanks for pointing it out, I'll update the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291