[PATCH] D126759: [clang][dataflow] Model calls returning optionals

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 13:12:16 PDT 2022


xazax.hun accepted this revision.
xazax.hun added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:161
 
+auto possiblyAliasedOptionalType() {
+  return hasUnqualifiedDesugaredType(
----------------
Does alias refers to a type alias in this case? I first parsed this as if this has something to do with pointers being aliased. I wonder if `possiblyOptionalAliasType` would read better (considering the optional type its own alias). Feel free to ignore. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126759/new/

https://reviews.llvm.org/D126759



More information about the cfe-commits mailing list