[clang] aaf04c7 - Fix an incorrect bit-width for storing attribute syntax information

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 11:24:58 PDT 2022


Author: Aaron Ballman
Date: 2022-06-01T14:24:51-04:00
New Revision: aaf04c72159109f37507589ba13ff034b73403c2

URL: https://github.com/llvm/llvm-project/commit/aaf04c72159109f37507589ba13ff034b73403c2
DIFF: https://github.com/llvm/llvm-project/commit/aaf04c72159109f37507589ba13ff034b73403c2.diff

LOG: Fix an incorrect bit-width for storing attribute syntax information

This field corresponds to the Syntax enumeration, and that gained
another entry in 1fdf952deeb9a02aa34794af3c1a7d13a30e068e. However,
the bit-field for storing the syntax used was not adjusted to handle
the extra field.

This turns out to be unobservable for HLSL attributes at the moment, so
there is no test coverage. But it's also not really an NFC change
either.

Added: 
    

Modified: 
    clang/include/clang/Basic/AttributeCommonInfo.h

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/Basic/AttributeCommonInfo.h b/clang/include/clang/Basic/AttributeCommonInfo.h
index 478b9df371209..9eff0966e458a 100644
--- a/clang/include/clang/Basic/AttributeCommonInfo.h
+++ b/clang/include/clang/Basic/AttributeCommonInfo.h
@@ -69,7 +69,7 @@ class AttributeCommonInfo {
   // Corresponds to the Kind enum.
   unsigned AttrKind : 16;
   /// Corresponds to the Syntax enum.
-  unsigned SyntaxUsed : 3;
+  unsigned SyntaxUsed : 4;
   unsigned SpellingIndex : 4;
 
 protected:


        


More information about the cfe-commits mailing list