[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

[Paul Robinson via Phabricator via cfe-commits]

probinson added a comment.

I'm in the middle of upstreaming PS5 support and I still didn't think of this... doh!



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5588
 
+  bool DefaultedSMFArePOD = !RawTriple.isPS4() && !RawTriple.isOSDarwin();
+
----------------
`isPS4()` => `isPS()` please.  This should be in effect for both PS4 and PS5.


================
Comment at: clang/test/Driver/clang_f_opts.c:602
+// RUN: %clang -### %s 2>&1 | FileCheck --check-prefix=CHECK-DEFAULTED-SMF-ARE-POD %s
+// RUN: %clang -### %s -target x86_64-scei-ps4 2>&1 | FileCheck --check-prefix=CHECK-NO-DEFAULTED-SMF-ARE-POD %s
+// RUN: %clang -### %s -target x86_64-scei-ps4 -fdefaulted-smf-are-pod 2>&1 | FileCheck --check-prefix=CHECK-DEFAULTED-SMF-ARE-POD %s
----------------
Please duplicate this line with `-target x86_64-sie-ps5`
(no need to duplicate both)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119051/new/

https://reviews.llvm.org/D119051