[PATCH] D126660: [OpenCL] Reword unknown extension pragma diagnostic

Sven van Haastregt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 08:42:54 PDT 2022


svenvh added a comment.

In D126660#3550356 <https://reviews.llvm.org/D126660#3550356>, @Anastasia wrote:

> Ok, makes sense! Thanks!
>
> Btw I was thinking we should provide some way for developers to know what extensions are being supported either through documentation or by querying clang somehow? I am guessing documentation would be easier to implement but harder to keep in sync?

I agree that would be nice to have.  That would also enable us to distinguish valid pragmaless extensions from garbage (e.g. mistyped extensions), and would also help `-cl-ext` parsing/diagnosing for example.  But that would require us to maintain a list of extensions inside Clang, which I believe is what we wanted to move away from (especially for extensions that only add library-like functionality)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126660/new/

https://reviews.llvm.org/D126660



More information about the cfe-commits mailing list