[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 08:23:44 PDT 2022


Anastasia added a comment.

In D124753#3546608 <https://reviews.llvm.org/D124753#3546608>, @python3kgae wrote:

> In D124753#3545779 <https://reviews.llvm.org/D124753#3545779>, @Anastasia wrote:
>
>> From the current change it seems to me that what you need to be testing is a just that the frontend options are being passed correctly? This should then be a driver test with `-###` checking for the options to be set for the frontend invocation...
>
> There's already a driver test with '-###' in https://reviews.llvm.org/D124751#change-af6Z62NjlfGb

This test doesn't seem to correspond to the change being added as you are changing the command-line flags. You don't actually add/generate any attributes in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124753/new/

https://reviews.llvm.org/D124753



More information about the cfe-commits mailing list