[PATCH] D126066: [clang] [WIP] Don't plumb access specifier attributes through Parser unnecessarily.

Martin Böhme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 04:37:18 PDT 2022


mboehme abandoned this revision.
mboehme added a comment.

Apologies, I had thoroughly misunderstood how this works. Specifically, what wasn't clear to me is that attributes added to the access specifier are added to every member below it until the next access specifier. With that, all of this code is obviously needed.

I'm using a custom test runner setup that unfortunately happened not to run the tests that ended up failing.

Abandoning this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126066/new/

https://reviews.llvm.org/D126066



More information about the cfe-commits mailing list