[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

Wed Jun 1 01:54:30 PDT 2022

martong marked 2 inline comments as done.
martong added a comment.

In D126560#3549408 <https://reviews.llvm.org/D126560#3549408>, @steakhal wrote:

> This isn't an NFC change. It's more than a refactor/cosmetic change.

Still, there is no visible change in the behavior, at least that is intended. Should it be an NFCi ?

> Please run some benchmarks to validate the assumed performance characteristics.

Yeah I've thought of it, here it is:
F23275670: image.png <https://reviews.llvm.org/F23275670>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126560/new/

https://reviews.llvm.org/D126560