[PATCH] D126672: [Driver] Add multiarch path for RISC-V

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 1 00:01:23 PDT 2022


Hahnfeld added a comment.

In D126672#3546782 <https://reviews.llvm.org/D126672#3546782>, @Hahnfeld wrote:

> In D126672#3546773 <https://reviews.llvm.org/D126672#3546773>, @MaskRay wrote:
>
>> This needs a test.
>
> There are no tests for any of the other architectures.

@MaskRay is this ok to land without the test? IMHO, if this part of the driver is to be tested, it should happen for all architectures and requires mock directories because the paths are only added to the list of include / library directories if they exist. This goes far beyond this patch, only adding a `case` to the existing method.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126672/new/

https://reviews.llvm.org/D126672



More information about the cfe-commits mailing list