[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

Tue May 31 13:39:57 PDT 2022

sammccall added a comment.

Landed as ce5ebf0b9113df8ccaec1bcfd6804fb16cdef69d <https://reviews.llvm.org/rGce5ebf0b9113df8ccaec1bcfd6804fb16cdef69d> but I had to revert due to test failures on windows:

- https://buildkite.com/llvm-project/premerge-checks/builds/94783
- http://45.33.8.238/win/59124/step_9.txt

Unfortunately neither of these give a stack trace, so I'm not yet sure what's wrong, beyond "some Optional is null when it shouldn't be".
A wild guess: `long` is shorter than a pointer on 64-bit windows, so that code doesn't even parse.
Indeed `(int)&global_var` doesn't parse for me on a 64-bit linux machine (32-bit int, 64-bit pointer).
The mystery in that case, though, is why the test output doesn't show parse error before crashing (TestTU is supposed to dump this unless you set ErrorOK).

It's late, but I'll try fixing and re-landing tomorrow.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126498/new/

https://reviews.llvm.org/D126498