[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

Tue May 31 12:11:31 PDT 2022

sammccall added a comment.

In D126397#3547438 <https://reviews.llvm.org/D126397#3547438>, @sammccall wrote:

> In D126397#3547060 <https://reviews.llvm.org/D126397#3547060>, @thakis wrote:
>
>> Should pseudo-gen honor LLVM_USE_HOST_TOOLS too? It looks like it's basically the same situation.
>
> Yes, I agree, it should. I'll send a patch.

Committed in 9d991da60df492a191b34aa3e75484ddd27e8930 <https://reviews.llvm.org/rG9d991da60df492a191b34aa3e75484ddd27e8930>

>> Regarding building native tools while cross compiling - for other tools so far, we’ve also had the option to pass an option like -DLLVM_TABLEGEN=path/to/llvm-tblgen. If all the needed native tools are provided that way, the build doesn’t need to set up the nested native cmake build while cross compiling. Should we prove a way to do that for this build time generation tool too?
>
> Yeah, it seems reasonable to spend a little bit more cmake complexity for this.
> I hope it can be done in a few lines (digging into it) esp given how hard it is to maintain non-bot-covered cmake configs.

Sent D126717 <https://reviews.llvm.org/D126717> (I verified this locally, but want to make sure I'm not misunderstanding what we want here).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126397/new/

https://reviews.llvm.org/D126397