[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

Damian Rouson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 31 09:46:23 PDT 2022


rouson added a comment.

On Mon, May 30, 2022 at 2:39 AM Andrzej Warzynski via Phabricator <reviews at reviews.llvm.org> wrote:

> 1. Lets rename `flang` as `flang-to-external-fc` regardless of what's decided for `flang-new`. That would already be a huge step forward (and  > would reflect accurately what the bash wrapper script actually does).

I support this.  I think the proposed new name is better reflects what the current flang script currently does and thereby reduces the likelihood of surprise when a user sees an error message from an external compiler.

> 2. As for the NAG test suite, I hope that we can agree not to use it as the condition for renaming `flang-new`. If it's decided that that's a valid > equirement, then I agree with @kiranchandramohan that we should find a way to openly track the progress towards the required pass rate
>
> (and how that's defined).

I agree.

> Perhaps we could discuss more in the call today?

Any news from the call?

Damian


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125788/new/

https://reviews.llvm.org/D125788



More information about the cfe-commits mailing list