[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 31 09:30:23 PDT 2022


beanz added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:1249
+    // Build TargetTriple from target_profile option for clang-dxc.
+    if (const Arg *A = Args.getLastArg(options::OPT_target_profile)) {
+      StringRef TargetProfile = A->getValue();
----------------
The `-T` flag is required for DXCMode, so the else of this should emit an error. That also means the code above that explicitly sets the OS to ShaderModel can be removed too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125585/new/

https://reviews.llvm.org/D125585



More information about the cfe-commits mailing list